Resend replication requests for finalized blocks that fail to verify #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think we have this problem for notarizations, because we first filter out the notarizations that are bad, don't we? |
yacovm
reviewed
Aug 28, 2025
epoch.go
Outdated
| @@ -1767,6 +1769,7 @@ func (e *Epoch) createFinalizedBlockVerificationTask(block Block, finalization F | |||
| e.Logger.Error("Failed to index finalization", zap.Error(err)) | |||
| return md.Digest | |||
| } | |||
| e.Logger.Info("Finalized block", zap.Uint64("round", md.Round), zap.Uint64("seq", md.Seq)) | |||
There was a problem hiding this comment.
Was this used for debugging?
yacovm
reviewed
Aug 28, 2025
yacovm
reviewed
Aug 28, 2025
yacovm
reviewed
Sep 2, 2025
epoch.go
Outdated
| @@ -1747,6 +1748,9 @@ func (e *Epoch) createFinalizedBlockVerificationTask(block Block, finalization F | |||
| verifiedBlock, err := block.Verify(context.Background()) | |||
| if err != nil { | |||
| e.Logger.Debug("Failed verifying block", zap.Error(err)) | |||
| // if we fail to verify the block, we re-add to request timeout | |||
| index := rand.Int() % len(finalization.QC.Signers()) | |||
There was a problem hiding this comment.
this rand is fairly deterministic in tests, and also not random in production.
Can we just read 2 random bytes from crypto random and reduce it modulo the node count? It'll be close enough to random, while not uniform, but good enough.
yacovm
reviewed
Sep 2, 2025
| @@ -562,3 +566,94 @@ func TestReplicationMalformedQuorumRound(t *testing.T) { | |||
| laggingNode.e.AdvanceTime(laggingNode.e.StartTime.Add(simplex.DefaultReplicationRequestTimeout * 2)) | |||
| laggingNode.storage.waitForBlockCommit(startSeq) | |||
| } | |||
|
|
|||
| func TestReplicationResendsFinalizedBlocksThatFailedVerification(t *testing.T) { | |||
samliok
force-pushed
the
resend-failed-verify
branch
from
b3da6fe to
09149a8
Compare
yacovm
reviewed
Sep 3, 2025
yacovm
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could add this for notarizations, but it seems like we are not planning on re-requesting notarizations?
This solves #187