Skip to content

chore: fully remove windows support special cases #4032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions scripts/build_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,6 @@ source "$AVALANCHE_PATH"/scripts/constants.sh

EXCLUDED_TARGETS="| grep -v /mocks | grep -v proto | grep -v tests/e2e | grep -v tests/load/c | grep -v tests/upgrade | grep -v tests/fixture/bootstrapmonitor/e2e"

if [[ "$(go env GOOS)" == "windows" ]]; then
# Test discovery for the antithesis test setups is broken due to
# their dependence on the linux-only Antithesis SDK.
EXCLUDED_TARGETS="${EXCLUDED_TARGETS} | grep -v tests/antithesis"
fi

TEST_TARGETS="$(eval "go list ./... ${EXCLUDED_TARGETS}")"

# shellcheck disable=SC2086
Expand Down
3 changes: 1 addition & 2 deletions tests/fixture/tmpnet/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,7 @@ the following non-test files:
| yaml/ | | Directory defining kubernetes resources in yaml format |
| check_monitoring.go | | Enables checking if logs and metrics were collected |
| defaults.go | | Defines common default configuration |
| detached_process_default.go | | Configures detached processes for darwin and linux |
| detached_process_windows.go | | No-op detached process configuration for windows |
| detached_process.go | | Configures detached processes |
| flagsmap.go | FlagsMap | Simplifies configuration of avalanchego flags |
| genesis.go | | Creates test genesis |
| kube.go | | Library for Kubernetes interaction |
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright (C) 2019-2024, Ava Labs, Inc. All rights reserved.
// See the file LICENSE for licensing terms.

//go:build linux || darwin || unix

package tmpnet

import (
Expand Down
12 changes: 0 additions & 12 deletions tests/fixture/tmpnet/detached_process_windows.go

This file was deleted.

4 changes: 2 additions & 2 deletions utils/storage/storage_unix.go
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// Copyright (C) 2019-2024, Ava Labs, Inc. All rights reserved.
// See the file LICENSE for licensing terms.

//go:build !windows && !openbsd
// +build !windows,!openbsd
//go:build !openbsd
// +build !openbsd

package storage

Expand Down
48 changes: 0 additions & 48 deletions utils/storage/storage_windows.go

This file was deleted.

19 changes: 0 additions & 19 deletions utils/ulimit/ulimit_windows.go

This file was deleted.

1 change: 0 additions & 1 deletion vms/rpcchainvm/runtime/subprocess/linux_stopper.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
//go:build linux
// +build linux

// ^ SIGTERM signal is not available on Windows
// ^ syscall.SysProcAttr only has field Pdeathsig on Linux

package subprocess
Expand Down