Fix noctx linter #4163
Open
Fix noctx linter #4163
+326
−160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
requested review from
aaronbuchwald,
maru-ava and
StephenButtolph
as code owners
joshua-kim
force-pushed
the
noctx
branch
3 times, most recently
from
b864fce to
2e04ac1
Compare
Comment on lines
+20
to
+21
| func Lookup(ctx context.Context, hostname string) (netip.Addr, error) { | ||
| ips, err := (&net.Resolver{}).LookupIPAddr(ctx, hostname) |
There was a problem hiding this comment.
This is a good change 👍
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Joshua Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
It's not a part of our CI, but I have a local version of golangci which is newer and this fires for me locally. This linter enforces the usage of newer context function signatures.
How this works
Fixes linter by adding contexts where appropriate.
How this was tested
CI
Need to be documented in RELEASES.md?
No