refactor: rawdb tests
#221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
RodrigoVillar/skip-freezer-inspection
to
main
September 3, 2025 13:50
ARR4N
force-pushed
the
arr4n/rawdb-test-refactor
branch
from
c75d74b to
d7fe647
Compare
ARR4N
commented
Sep 3, 2025
ARR4N
commented
Sep 3, 2025
RodrigoVillar
approved these changes
Sep 3, 2025
JonathanOppenheimer
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The need for examples to be in
package rawdb_testmade it difficult to test other code that relied on non-exportedrawdbidentifiers.How this works
database.libevm_test.gotoexamples.libevm_test.gowithout any change.database.libevm_test.goto be inpackage rawdband extend theWithSkipFreezers()test.How this was tested
No change at all to testable examples. The
WithSkipFreezers()test now touches both the happy and (specific) error paths to demonstrate exact behaviour (under the old approach it could have just been that there was no error, even without the option).