Skip to content

Conversation

igor-vovk
Copy link

Hi and thank you for your work on this library!

We are trying to use the library as a part of GRPC adoption process, and thus we needed to bring it to the latest versions of everything. This PR is quite heavy on changes, from the major library updates:

  • Added Scala 3.3 compilation target (latest LTS release)
  • Updated cats-effect from v2 to v3.
  • Updated Akka Http
  • protobuf and grpc libraries were updated to their latest versions
  • latest sbt version

Notable changes:

  • Updating cats-effect to v3 required an addition of LiftToFuture class, since there is no way to convert F to Future in latest cats-effect library
  • Updating Akka-Http required a little bit different approach when working with Content-Type headers. Akka's Content-Type class constructor is now package-private. So the header is now defined either as a part of RequestEntity or during the serialization stage.
  • fixed protoc binary download on ARM-architecture (M1 Macs)
  • fixed test flakiness because of use System.nanoTime when creating ReflectionGrpcBridge (non-unique)
  • unapply pattern when defining variables in tests (val Some(...) = ...) was throwing an error and required adding @unchecked, decided to remove it and match against particular wrappers

Further improvements:

  • I want to open a separate PR with migration from Akka to Pekko. This will require changing namespaces. Please tell WDYT about that?

@igor-vovk
Copy link
Author

Hi! It seems this library is not supported anymore, so I wrote https://github.com/igor-vovk/connect-rpc-scala. As a plus, it is compliant with connect-rpc protoc client plugins. Not sure if you would want to mark this library as unsupported.

@augi
Copy link
Member

augi commented Sep 17, 2025

Sorry, I did get any notification about this PR :( If you resolve the conflicts, I will merge it ASAP.

@augi
Copy link
Member

augi commented Sep 17, 2025

But I'm afraid that I will not be able to publish the new version, because Maven Central publishing has been changed again :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants