Skip to content

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Oct 8, 2025

Please provide the issue number

Issue number: closes #1029

Summary

Changes

This pull request updates the examples to the latest nuget package verions and Powertools v3
This also fixes an issue in CI when testing if the string ends with PTENV/
It fails because ECS adds the app id AWS_ECS_EC2
Now we only check for Contains

[xUnit.net 00:00:00.30]       Assert.EndsWith() Failure: String end does not match
--
[xUnit.net 00:00:00.30]       String:       "PT/Logging/3.0.0 PTEnv/AWS_ECS_EC2"
[xUnit.net 00:00:00.30]       Expected end: "PTEnv/"

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the tests label Oct 8, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 8, 2025
@github-actions github-actions bot added the internal Maintenance changes label Oct 8, 2025
@hjgraca hjgraca requested a review from sthulb October 8, 2025 12:17
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.10%. Comparing base (cfa4560) to head (98f1342).
⚠️ Report is 14 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1030      +/-   ##
===========================================
- Coverage    78.13%   78.10%   -0.03%     
===========================================
  Files          298      298              
  Lines        12003    12003              
  Branches      1441     1441              
===========================================
- Hits          9378     9375       -3     
- Misses        2163     2164       +1     
- Partials       462      464       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sthulb
sthulb previously approved these changes Oct 8, 2025
Copy link

sonarqubecloud bot commented Oct 8, 2025

@hjgraca hjgraca merged commit b060344 into develop Oct 8, 2025
9 of 10 checks passed
@hjgraca hjgraca deleted the chore/update-examples branch October 8, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: Update examples to latest versions of nuget packages

2 participants