Skip to content

chore(gitignore): add .kiro, .claude, .amazonq to prevent deletion #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 25, 2025

Conversation

nikkhilaaryan
Copy link
Contributor

@nikkhilaaryan nikkhilaaryan commented Aug 22, 2025

Issue number: #2020

Summary

Kiro, Claude, and Amazon Q create local configuration folders (.kiro/, .claude/, .amazonq/).
When developers run git clean, these folders may be deleted, causing loss of settings and session data.

Changes

  • Added .kiro/, .claude/, and .amazonq/ to the root .gitignore.
  • Added .github/instructions file to explain why these folders are ignored.

User experience

Before: Running git clean could remove .kiro, .claude, or .amazonq folders, wiping out custom settings.
After: These folders are preserved, protecting developer configurations.

Checklist

  • Meet tenets criteria
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
  • PR title follows conventional commit semantics

Is this a breaking change?

No. This is a non-breaking maintenance update.

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@phipag
Copy link
Contributor

phipag commented Aug 23, 2025

Thank you for sending this PR @nikkhilaaryan! 🚀

Could you make sure the PR follows our PR template and the semantic commit title?

Here is a reference PR from our Python repository for the same change: aws-powertools/powertools-lambda-python#7137

Do you mind also adding .github/instructions?

@phipag phipag self-requested a review August 23, 2025 10:07
@nikkhilaaryan nikkhilaaryan changed the title add: .kiro, .claude, .amazonq to .gitignore to prevent deletion chore(gitignore): add .kiro, .claude, .amazonq to prevent deletion Aug 24, 2025
@nikkhilaaryan
Copy link
Contributor Author

Hi @phipag,

Thanks for the review! I’ve updated the PR to:

  • Follow the PR template
  • Update the title to follow semantic commit style
  • Add .github/instructions with details about the ignored folders

Please let me know if there’s anything else I should adjust.

Copy link
Contributor

@phipag phipag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nikkhilaaryan. I think this was a misunderstanding. I meant that you should add the .github/instructions file to .gitignore.

Copy link
Contributor

@phipag phipag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small suggestion. Let's move all these files/folder just under an # LLMs command.

You can directly commit these suggestions on GitHub into this PR.

dreamorosi and others added 2 commits August 25, 2025 15:35
Co-authored-by: Philipp Page <[email protected]>
Co-authored-by: Philipp Page <[email protected]>
Copy link

@phipag phipag merged commit 5647e0d into aws-powertools:main Aug 25, 2025
6 checks passed
@phipag
Copy link
Contributor

phipag commented Aug 25, 2025

Thanks @nikkhilaaryan, I merged your PR. Congrats 🚀

@nikkhilaaryan nikkhilaaryan deleted the protect-kiro-folder branch August 25, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants