Skip to content

improv(idempotency): Prevent error when AWS_LAMBDA_FUNCTION_NAME is not passed in the Idempotency Persistence Layer #4327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025

Conversation

sdangol
Copy link
Contributor

@sdangol sdangol commented Aug 13, 2025

Summary

This PR prevents errors when initializing the persistence layer class in non Lambda execution environment (eg: test environments where AWS_LAMBDA_FUNCTION_NAME is not defined)

Changes

Please provide a summary of what's being changed

  • Passed an empty string as the default value when setting the value of idempotencyKeyPrefix and removed the required error message
  • Added test to verify the fallback behaviour

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #4326


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

…x when initializing the persistence layer class
@boring-cyborg boring-cyborg bot added idempotency This item relates to the Idempotency Utility tests PRs that add or change tests labels Aug 13, 2025
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Aug 13, 2025
@sdangol sdangol self-assigned this Aug 13, 2025
@sdangol sdangol requested a review from svozza August 13, 2025 16:20
Copy link

@svozza svozza merged commit 17845d0 into main Aug 13, 2025
34 checks passed
@svozza svozza deleted the fix/fallback-idempotency-key-prefix branch August 13, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idempotency This item relates to the Idempotency Utility size/S PR between 10-29 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Prevent error when AWS_LAMBDA_FUNCTION_NAME is not passed in the Idempotency Persistence Layer
3 participants