Skip to content

As Glue limits comments to 255 characters, we may need to truncate them #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025
Merged

As Glue limits comments to 255 characters, we may need to truncate them #174

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3baf57
As Glue limits comments to 255 characters, we may need to truncate them.
mikko-leppanen-fonecta-com Oct 24, 2018
98a0373
Resolved conflicts in #38
manabery May 23, 2025
986c5c5
truncate comments to 255 characters for partition key
manabery May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions utilities/Hive_metastore_migration/src/hive_metastore_migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,14 @@ def transform_df_with_idx(self, df, id_col, idx, payloads_column_name, payload_t
return self.sql_context.createDataFrame(rdd_result, schema)

def transform_ms_partition_keys(self, ms_partition_keys):
def extract_row(row):
def truncate(x):
return x[:255] if hasattr(x,"__getitem__") else x
return (
row['PKEY_NAME'],
row['PKEY_NAME'],
truncate(row['PKEY_COMMENT'])
)
return self.transform_df_with_idx(
df=ms_partition_keys,
id_col="TBL_ID",
Expand All @@ -487,7 +495,7 @@ def transform_ms_partition_keys(self, ms_partition_keys):
StructField(name="comment", dataType=StringType()),
]
),
payload_func=lambda row: (row["PKEY_NAME"], row["PKEY_TYPE"], row["PKEY_COMMENT"]),
payload_func=extract_row,
)

def transform_ms_partition_key_vals(self, ms_partition_key_vals):
Expand All @@ -511,6 +519,14 @@ def transform_ms_bucketing_cols(self, ms_bucketing_cols):
)

def transform_ms_columns(self, ms_columns):
def extract_row(row):
def truncate(x):
return x[:255] if hasattr(x,"__getitem__") else x
return (
row['COLUMN_NAME'],
row['TYPE_NAME'],
truncate(row['COMMENT'])
)
return self.transform_df_with_idx(
df=ms_columns,
id_col="CD_ID",
Expand All @@ -523,7 +539,7 @@ def transform_ms_columns(self, ms_columns):
StructField(name="comment", dataType=StringType()),
]
),
payload_func=lambda row: (row["COLUMN_NAME"], row["TYPE_NAME"], row["COMMENT"]),
payload_func=extract_row,
)

def transform_ms_skewed_col_names(self, ms_skewed_col_names):
Expand Down