Skip to content

Conversation

mludvig
Copy link
Contributor

@mludvig mludvig commented Oct 8, 2025

As described in #942 the generated output briefly disappears after the generation is completed and the re-appears again. This simple one-liner fixes the issue but not calling the 'reset' action (which clears everything) in the 'goodbye' state.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Yukinobu-Mine
Copy link
Contributor

Yukinobu-Mine commented Oct 11, 2025

@mludvig Thank you for your contribution! I have tested your changes and found no problems.
I have a question: Do you think we should leave a comment explaining why we're removing the reset action from goodbye event?

@mludvig
Copy link
Contributor Author

mludvig commented Oct 12, 2025

Removed the comment :)

@Yukinobu-Mine Yukinobu-Mine merged commit 09d203b into aws-samples:v3 Oct 14, 2025
8 checks passed
@Yukinobu-Mine
Copy link
Contributor

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants