Agent Health Metric for Windows Events Filtering #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paamicky
force-pushed
the
feature/windows-regex-filtering
branch
2 times, most recently
from
615200a to
9fb255f
Compare
okankoAMZ
reviewed
Jul 22, 2025
| @@ -34,6 +35,9 @@ const ( | |||
| flagSELinux = "selinux" | |||
| flagROSA = "rosa" | |||
| separator = " " | |||
| flagWindowsEventIDs = "windows_event_ids" | |||
There was a problem hiding this comment.
could you move this under flagROSA?
flagSELinux = "selinux"
flagROSA = "rosa"
flagWindowsEventIDs = "windows_event_ids"
flagWindowsEventFilters = "windows_event_filters"
flagWindowsEventLevels = "windows_event_levels"
separator = " "
| @@ -6,6 +6,7 @@ package useragent | |||
| import ( | |||
| "fmt" | |||
| "os" | |||
| "reflect" | |||
There was a problem hiding this comment.
Looks like reflect is used for type validation below
| @@ -74,6 +78,35 @@ var _ UserAgent = (*userAgent)(nil) | |||
| func (ua *userAgent) SetComponents(otelCfg *otelcol.Config, telegrafCfg *telegraf.Config) { | |||
| for _, input := range telegrafCfg.Inputs { | |||
| ua.inputs.Add(input.Config.Name) | |||
|
|
|||
| if input.Config.Name == "windows_event_log" { | |||
There was a problem hiding this comment.
nit: can we not nest this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Currently, there is no way to know the number of customers using the windows event filtering in the Agent's configuration. This PR address this issue by adding the feature as part of the user-agent string for detection during API calls to CloudWatch.
Description of changes
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Filter flags been added to the user-agent input string.
Dashboard showing usage of filters: Team Dashboard
Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.