Skip to content

Implement disableMarkdownRendering setting to allow users to disable markdown … #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alex-bellomo
Copy link
Contributor

@alex-bellomo alex-bellomo commented Jul 5, 2025

Issue #, if available:

  • None.

Why make this change:

  • This was personally bothering me as a user - asking Q to generate markdown-formatted text (e.g. CR descriptions) would result in rendered markdown. I would have to re-format the output after pasting it into CRUX.

Description of changes:

  • Created a new chat setting, disableMarkdownRendering, that users can use to disable markdown rendering in the responses. The setting defaults to true, unless specified false by the user.
  • When the disableMarkdownRendering setting is set to false, skip the markdown-related parsers in parse.rs.
  • Added unit tests to validate behavior.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

EDIT: Updated name of setting from enableMarkdown to disableMarkdownRendering.

Copy link
Contributor

@brandonskiser brandonskiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the default is to render markdown, can we change this setting to instead be: chatDisableMarkdownRendering? More clear that this is a setting override (and enableMarkdown is kind of confusing on its own imo)

@alex-bellomo alex-bellomo force-pushed the feature/enable-markdown-setting branch from 9ea3c4e to bacc9b3 Compare July 23, 2025 01:18
@alex-bellomo alex-bellomo reopened this Jul 23, 2025
@@ -91,6 +93,7 @@ impl TryFrom<&str> for Setting {
"mcp.noInteractiveTimeout" => Ok(Self::McpNoInteractiveTimeout),
"mcp.loadedBefore" => Ok(Self::McpLoadedBefore),
"chat.defaultModel" => Ok(Self::ChatDefaultModel),
"chat.enableMarkdown" => Ok(Self::ChatDisableMarkdownRendering),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't updated to chat.disableMarkdownRendering

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Fixed below!

@alex-bellomo alex-bellomo changed the title Implement enableMarkdown settings to allow users to disable markdown … Implement disableMarkdown settings to allow users to disable markdown … Jul 26, 2025
@alex-bellomo alex-bellomo force-pushed the feature/enable-markdown-setting branch from 26d5e25 to 4aaf343 Compare July 26, 2025 18:49
@alex-bellomo alex-bellomo changed the title Implement disableMarkdown settings to allow users to disable markdown … Implement disableMarkdownRendering setting to allow users to disable markdown … Jul 26, 2025
@brandonskiser brandonskiser merged commit df8752f into aws:main Jul 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants