Implement disableMarkdownRendering setting to allow users to disable markdown … #2236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonskiser
requested changes
Jul 22, 2025
alex-bellomo
force-pushed
the
feature/enable-markdown-setting
branch
from
9ea3c4e to
bacc9b3
Compare
brandonskiser
requested changes
Jul 26, 2025
| @@ -91,6 +93,7 @@ impl TryFrom<&str> for Setting { | |||
| "mcp.noInteractiveTimeout" => Ok(Self::McpNoInteractiveTimeout), | |||
| "mcp.loadedBefore" => Ok(Self::McpLoadedBefore), | |||
| "chat.defaultModel" => Ok(Self::ChatDefaultModel), | |||
| "chat.enableMarkdown" => Ok(Self::ChatDisableMarkdownRendering), | |||
There was a problem hiding this comment.
This wasn't updated to chat.disableMarkdownRendering
There was a problem hiding this comment.
Whoops! Fixed below!
alex-bellomo
changed the title
alex-bellomo
force-pushed
the
feature/enable-markdown-setting
branch
from
26d5e25 to
4aaf343
Compare
alex-bellomo
changed the title
brandonskiser
approved these changes
Jul 28, 2025
Merged
brandonskiser
pushed a commit
that referenced
this pull request
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Why make this change:
Description of changes:
chatsetting,disableMarkdownRendering, that users can use to disable markdown rendering in the responses. The setting defaults totrue, unless specifiedfalseby the user.disableMarkdownRenderingsetting is set tofalse, skip the markdown-related parsers inparse.rs.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
EDIT: Updated name of setting from
enableMarkdowntodisableMarkdownRendering.