chore(dependencies): build with upgraded dependencies fails #34957
+419
−415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
pr/needs-maintainer-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Related to the #34888 PR.
This PR contains the commit created by the Github action (that doesn't build) and another commit with the fix (making it easier to review).
Reason for this change
Version 6.0.0 of
@types/minimatchgot released on NPM which deprecates the package and now the package doesn't contain code anymore (see files on NPM).We cannot upgrade our version of
globas this requires Node.js 20, see #33231Description of changes
Pin
@types/minimatchto the previous working version.This has a side effect: lerna uses a pinned version of @types/minimatch (you can verify this with
yarn why @types/minimatchwith version3.x.x, now it will use5.1.2. As the build still passes I think this doesn't have consequences.I also removed
@types/minimatchfrom thenohoistas this line doesn't have any effect since all the packages in the repo now use the same version.Description of how you validated changes
Build, integ and unit tests. Ran
yarn why @types/minimatchto confirm that all the packages use the same version of minimatch.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license