Skip to content

chore(dependencies): build with upgraded dependencies fails #34957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 29, 2025

Conversation

leonmk-aws
Copy link
Contributor

@leonmk-aws leonmk-aws commented Jul 10, 2025

Issue # (if applicable)

Related to the #34888 PR.

This PR contains the commit created by the Github action (that doesn't build) and another commit with the fix (making it easier to review).

Reason for this change

Version 6.0.0 of @types/minimatch got released on NPM which deprecates the package and now the package doesn't contain code anymore (see files on NPM).

We cannot upgrade our version of glob as this requires Node.js 20, see #33231

Description of changes

Pin @types/minimatch to the previous working version.

This has a side effect: lerna uses a pinned version of @types/minimatch (you can verify this with yarn why @types/minimatch with version 3.x.x, now it will use 5.1.2. As the build still passes I think this doesn't have consequences.

I also removed @types/minimatch from the nohoist as this line doesn't have any effect since all the packages in the repo now use the same version.

Description of how you validated changes

Build, integ and unit tests. Ran yarn why @types/minimatch to confirm that all the packages use the same version of minimatch.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation and others added 2 commits July 10, 2025 15:09
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
@leonmk-aws leonmk-aws marked this pull request as ready for review July 10, 2025 16:03
@aws-cdk-automation aws-cdk-automation requested a review from a team July 10, 2025 16:03
@github-actions github-actions bot added the p2 label Jul 10, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 10, 2025
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-maintainer-review This PR needs a review from a Core Team Member labels Jul 10, 2025
@Abogical Abogical self-assigned this Jul 29, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 29, 2025
Copy link
Contributor

mergify bot commented Jul 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Jul 29, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2dc1ed3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1da883e into aws:main Jul 29, 2025
20 checks passed
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants