Skip to content

feat(aws-stepfunctions-tasks/evaluate-expression): Allow configure EvaluateExpression Lambda architecture #34975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

BalmungSan
Copy link

Issue #34974

Closes #34974

Reason for this change

Allows users to configure the Lambda Architecture used by EvaluateExpression.

Description of changes

Exposes an optional property on the EvaluateExpressionProps and in the EvalNodejsSingletonFunctionProps to configure the Architecture, and defaults to x86_64 to maintain compatibility.

Describe any new or updated permissions being added

None

Description of how you validated changes

If you can publish a snapshot from this PR, we can test the changes in our internal project.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 11, 2025 22:26
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels Jul 11, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ The title prefix of this pull request must be one of "feat|fix|build|chore|ci|docs|style|refactor|perf|test|revert"
❌ The first word of the pull request title should not be capitalized. If the title starts with a CDK construct, it should be in backticks "``".

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@BalmungSan BalmungSan changed the title Allow configure EvaluateExpression Lambda architecture feat(aws-stepfunctions-tasks/evaluate-expression): Allow configure EvaluateExpression Lambda architecture Jul 11, 2025
@BalmungSan BalmungSan force-pushed the feature/34974/configure-evaluate-expression-architecture branch 2 times, most recently from 3765f19 to d8be809 Compare July 13, 2025 16:06
@BalmungSan BalmungSan force-pushed the feature/34974/configure-evaluate-expression-architecture branch from 0cc63e1 to 8c4f0de Compare July 13, 2025 16:23
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7023141
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@BalmungSan
Copy link
Author

BalmungSan commented Jul 13, 2025

I just realized that this file: https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/custom-resource-handlers/test/custom-resources-framework/expected/singleton-function-eval-nodejs.ts is not the real source code, since the real file is being generated.

I don't understand the mechanism that generates that file, nor could I find where I would need to make the change. Thus, this is as far as I can go. I hope someone can pick this up and finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-stepfunctions-tasks/evaluate-expression): Support configuring the lambda architecture
2 participants