-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(aws-stepfunctions-tasks/evaluate-expression
): Allow configure EvaluateExpression
Lambda architecture
#34975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ The title prefix of this pull request must be one of "feat|fix|build|chore|ci|docs|style|refactor|perf|test|revert"
❌ The first word of the pull request title should not be capitalized. If the title starts with a CDK construct, it should be in backticks "``".
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed, add Clarification Request
to a comment.
EvaluateExpression
Lambda architectureaws-stepfunctions-tasks/evaluate-expression
): Allow configure EvaluateExpression
Lambda architecture
3765f19
to
d8be809
Compare
0cc63e1
to
8c4f0de
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
I just realized that this file: https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/custom-resource-handlers/test/custom-resources-framework/expected/singleton-function-eval-nodejs.ts is not the real source code, since the real file is being generated. I don't understand the mechanism that generates that file, nor could I find where I would need to make the change. Thus, this is as far as I can go. I hope someone can pick this up and finish it. |
Issue #34974
Closes #34974
Reason for this change
Allows users to configure the Lambda
Architecture
used byEvaluateExpression
.Description of changes
Exposes an optional property on the
EvaluateExpressionProps
and in theEvalNodejsSingletonFunctionProps
to configure theArchitecture
, and defaults tox86_64
to maintain compatibility.Describe any new or updated permissions being added
None
Description of how you validated changes
If you can publish a snapshot from this PR, we can test the changes in our internal project.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license