Skip to content

feat: Add support for hierarchical ARNs in Arn utility #34988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

murphm8
Copy link

@murphm8 murphm8 commented Jul 14, 2025

Reason for this change

Some AWS services are beginning to provide hierarchical arns for finer grained resource permissions management. AWS PCS is one of those services.

Description of changes

The Arn utility has been updated to support properly resolving the resource and resourceName for hierarchical ARNs. Previously, using the slash ARN support, it would return the parent resource type for resource and resourceName would include the entire rest of the ARN string.

I attempted to make this as minimal a change as possible. I followed TS best practices adding an optional "options" argument to the Split method in order to support hierarchical ARN depth configuration.

Describe any new or updated permissions being added

None

Description of how you validated changes

Added unit tests for the hierarchical ARN support, and existing unit tests continue to pass.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@murphm8 murphm8 requested a review from a team as a code owner July 14, 2025 20:47
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jul 14, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team July 14, 2025 20:47
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ The first word of the pull request title should not be capitalized. If the title starts with a CDK construct, it should be in backticks "``".

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

if (!resourceName) {
resourceName = '';
resource = resourceParts[targetIndex];
resourceName = resourceParts[targetIndex + 1];
Copy link
Author

@murphm8 murphm8 Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f736efa
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants