Skip to content

ci(cdk-release): fix bug marking stable changes as alpha #35012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Abogical
Copy link
Member

@Abogical Abogical commented Jul 18, 2025

Issue #34907

Closes #34907.

Reason for this change

Changelog generation sometimes treats stable changes as alpha changes.

Description of changes

  • "BREAKING CHANGE TO EXPERIMENTAL CHANGES" is changed to just "BREAKING CHANGES" as breaking L1 changes can be included in that list.
  • alpha package scopes will not be treated as equal to stable package scopes.

Describe any new or updated permissions being added

No new permissions are added.

Description of how you validated changes

Unit tests added.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. p1 labels Jul 18, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team July 18, 2025 11:45
@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label Jul 18, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 18, 2025
@Abogical Abogical force-pushed the fix-changelog-marks-stable-as-alpha branch from 585a7ae to 27a6278 Compare July 18, 2025 11:54
- "BREAKING CHANGE TO EXPERIMENTAL CHANGES" is changed to just "BREAKING CHANGES" as breaking L1 changes can be included in that list.
- alpha package scopes will not be treated as equal to stable package scopes.

Fixes #34907
@Abogical Abogical force-pushed the fix-changelog-marks-stable-as-alpha branch from 27a6278 to b7b2fbe Compare July 18, 2025 12:02
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b7b2fbe
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p1 pr/needs-maintainer-review This PR needs a review from a Core Team Member valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ec2: change marked as alpha in release notes
2 participants