-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(lambda-runtime): change fallback for latest lambda node runtime to node 22.x #35764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kumvprat
wants to merge
12
commits into
main
Choose a base branch
from
custom_resource_fallback_runtime
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+110,556
−168,956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to node 22 in regions where LATEST_NODE_RUNTIME is not a fact
aws-cdk-automation
previously requested changes
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
|
kumsmrit
reviewed
Oct 16, 2025
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
contribution/core
This is a PR that came from AWS.
p2
pr/needs-maintainer-review
This PR needs a review from a Core Team Member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
For #34635, moving the fallback of latest lambda node runtime to node 22.x
Description of changes
Changed fallback in
determineLatestNodeRuntime
to Nodejs 22.x for users that use AWS account in regions which don't have aregional fact presentDescription of how you validated changes
Ran all unit and integration tests to check that the change is valid
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license