Skip to content

Conversation

kumvprat
Copy link
Contributor

@kumvprat kumvprat commented Oct 16, 2025

Reason for this change

For #34635, moving the fallback of latest lambda node runtime to node 22.x

Description of changes

Changed fallback in determineLatestNodeRuntime to Nodejs 22.x for users that use AWS account in regions which don't have aregional fact present

Description of how you validated changes

Ran all unit and integration tests to check that the change is valid

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…to node 22 in regions where LATEST_NODE_RUNTIME is not a fact
@github-actions github-actions bot added the p2 label Oct 16, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team October 16, 2025 16:32
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 16, 2025
@kumvprat kumvprat changed the title chore: Change the determineLatestNodeRuntime method call to fallback to node 22 in regions where LATEST_NODE_RUNTIME is not a fact fix(lambda-runtime): change fallback for latest lambda node runtime to node 22.x Oct 16, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@kumvprat
Copy link
Contributor Author

Exemption requested as the change won't affect any tests

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 16, 2025
@kumvprat kumvprat requested a review from a team as a code owner October 17, 2025 15:37
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 17, 2025 15:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@kumvprat kumvprat removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Oct 21, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants