-
Notifications
You must be signed in to change notification settings - Fork 4.3k
docs: fix wording in FEATURE_FLAGS.md
for clarity
#35789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
FEATURE_FLAGS.md
for clarity
FEATURE_FLAGS.md
for clarityFEATURE_FLAGS.md
for clarity
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments below
The file is generated from the source here: https://github.com/aws/aws-cdk/blob/main/packages%2Faws-cdk-lib%2Fcx-api%2Flib%2Ffeatures.ts Don't change it by hand, they won't work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but this file is generated from another data source (some .ts
file somewhere).
Search the code base for that original string and edit the other one.
Pull request has been modified.
Issue # (if applicable)
Closes #.
Reason for this change
Description of changes
Describe any new or updated permissions being added
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license