Skip to content

Conversation

garysassano
Copy link
Contributor

@garysassano garysassano commented Oct 21, 2025

Issue # (if applicable)

Closes #.

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 21, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team October 21, 2025 01:21
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Oct 21, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@garysassano garysassano changed the title Fix wording in FEATURE_FLAGS.md for clarity docs: Fix wording in FEATURE_FLAGS.md for clarity Oct 21, 2025
@garysassano garysassano changed the title docs: Fix wording in FEATURE_FLAGS.md for clarity docs: Fix wording in FEATURE_FLAGS.md for clarity Oct 21, 2025
@ozelalisen ozelalisen self-assigned this Oct 21, 2025
@ozelalisen ozelalisen changed the title docs: Fix wording in FEATURE_FLAGS.md for clarity docs: fix wording in FEATURE_FLAGS.md for clarity Oct 21, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 21, 2025 06:55

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Member

@ozelalisen ozelalisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments below

@mrgrain
Copy link
Contributor

mrgrain commented Oct 21, 2025

The file is generated from the source here: https://github.com/aws/aws-cdk/blob/main/packages%2Faws-cdk-lib%2Fcx-api%2Flib%2Ffeatures.ts

Don't change it by hand, they won't work.

Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but this file is generated from another data source (some .ts file somewhere).

Search the code base for that original string and edit the other one.

@mergify mergify bot dismissed stale reviews from rix0rrr and ozelalisen October 21, 2025 10:00

Pull request has been modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants