-
Notifications
You must be signed in to change notification settings - Fork 144
Implement more options for x509 CLI #2735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you rebase this onto the latest on main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2735 +/- ##
==========================================
- Coverage 78.93% 78.64% -0.29%
==========================================
Files 677 678 +1
Lines 115525 116334 +809
Branches 16250 16302 +52
==========================================
+ Hits 91187 91492 +305
- Misses 23542 24053 +511
+ Partials 796 789 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There are a few failing in the X509 comparison tests: https://github.com/aws/aws-lc/actions/runs/18593051373/job/53012312901?pr=2735
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Issues:
Resolves #CryptoAlg-3386
Description of changes:
Implement the following options for x509 cli command:
Call-outs:
I made several edits to the test utilities functions that involve comparing AWS-LC and OpenSSL's certificate outputs. These functions are moved to a centralized location to make the code look cleaner.
Testing:
Unit tests added, including missing coverage for some existing x509 options.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.