[C++] SDKs to track feature Ids for GZip compression #3512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kai-ion
force-pushed
the
Atsun
branch
2 times, most recently
from
190b178 to
d4f2b00
Compare
sbiscigl
reviewed
Aug 13, 2025
| @@ -54,6 +54,20 @@ class AmazonWebServiceRequestMock : public Aws::AmazonWebServiceRequest | |||
| auto bodyString = ss.str(); | |||
| return bodyString.find("TestErrorInBodyOfResponse") != std::string::npos; | |||
| } | |||
|
|
|||
| Aws::Client::CompressionAlgorithm GetSelectedCompressionAlgorithm(Aws::Client::RequestCompressionConfig config) const override { | |||
There was a problem hiding this comment.
do we actually need this change?
| } | ||
| }; | ||
|
|
||
| class ClientHolder { |
There was a problem hiding this comment.
dont think we need this client holder
sbiscigl
reviewed
Aug 13, 2025
| }; | ||
|
|
||
| TEST_F(CloudWatchTest, TestUserAgentCompressionTracking) { | ||
| #if defined(ENABLED_ZLIB_REQUEST_COMPRESSION) && ENABLED_ZLIB_REQUEST_COMPRESSION == 1 |
There was a problem hiding this comment.
lets change this to
#ifndef ENABLED_ZLIB_REQUEST_COMPRESSION
GTEST_SKIP() << "ZLIB compression not available in this build";
#endif
... rest of test
kai-ion
force-pushed
the
Atsun
branch
3 times, most recently
from
95768b4 to
32ae7a9
Compare
- Add test to verify 'L' metric appears in User-Agent when gzip compression is used - Enable compression in test setup and mock client - Validate business metrics tracking for request compression feature update logic for compression unit test
sbiscigl
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.