Skip to content

feat(auth): add IAM credentials LSP requests to AuthUtils and auth2 #7507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 76 commits into
base: feature/flare-mega
Choose a base branch
from

Conversation

liramon1
Copy link
Contributor

@liramon1 liramon1 commented Jun 17, 2025

Problem

The authentication flow does not make requests to IAM credentials endpoints on Flare and does not provide places for clients to input long-term IAM credentials or STS credentials.

Solution

  • Add IAM and STS credentials options to LanguageClientAuth requests
  • Add IAM credentials option and form to webview
  • Modify AuthUtils to switch between SsoLogin and IamLogin strategies
  • Modify clients to support IAM and STS credentials
  • Add IAM and STS credentials unit tests

This feature is split into multiple PRs (in order):

  1. feat(auth): add support for IAM profile management and flare endpoints #7659
  2. feat(auth): add STS credential management #7661

Meanwhile, we are making changes to language-servers and language-server-runtimes such that authentication for IAM credentials can happen on Flare side.

Tests will work with this version of language-server-runtimes:
https://github.com/liramon1/language-server-runtimes/tree/feature/flare-iam

and this version of language-servers:
https://github.com/liramon1/language-servers/tree/liramon/flare-iam

Please reference these when reviewing our work


License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

yuxianrz and others added 29 commits July 15, 2025 10:55
bywang56 pushed a commit that referenced this pull request Jul 31, 2025
#7659)

## Problem
The webview does not support IAM credentials input and endpoint to LSP
does not support IAM credentials and IAM profiles.

## Solution
This is part of #7507.

- Add IAM credentials option and form to webview
- Modify AuthUtils to switch between SsoLogin and IamLogin strategies
- Add startIamCredentialSetup in backend_amazonq

Meanwhile, we are making changes to language-servers and
language-server-runtimes such that authentication for IAM credentials
can happen on Flare side.

working branches:

https://github.com/liramon1/language-server-runtimes/tree/feature/flare-iam
https://github.com/liramon1/language-servers/tree/liramon/flare-iam

Current PR built upon flare-mega branch and is working to merge with
flare-mega branch. This PR fails a web test that flare-mega branch is
also failing, at the same place.

---

- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants