Skip to content

feat(amazonq): adapt feature flag for CodeReviewInChat, emit metrics for explainIssue, applyFix #7739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 30, 2025

Conversation

BlakeLazarine
Copy link
Contributor

@BlakeLazarine BlakeLazarine commented Jul 23, 2025

Problem

Adapt the CodeReviewInChat feature flag so that it applies to redirecting the commands which invoke /review

Emit telemetry events for explainIssue and applyFix

Solution

Move the feature flag value to a common location where it will be consumed

add telemetry emits based on earlier implementation

Set CodeReviewInChat feature flag to true (Requires merge after aws/language-servers#1964)

The duplicate code was not introduced by the commits in this PR, so we can ignore.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@BlakeLazarine BlakeLazarine requested a review from a team as a code owner July 23, 2025 18:40
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@BlakeLazarine BlakeLazarine changed the title Code review tool feat(amazonq): adapt feature flag for CodeReviewInChat, emit metrics for explainIssue, applyFix Jul 23, 2025
@BlakeLazarine BlakeLazarine reopened this Jul 23, 2025
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@BlakeLazarine
Copy link
Contributor Author

/retryBuilds

@@ -64,14 +68,20 @@ export function registerCommands(provider: AmazonQChatViewProvider) {
registerShellCommandShortCut('aws.amazonq.rejectCmdExecution', 'reject-shell-command', provider),
registerShellCommandShortCut('aws.amazonq.stopCmdExecution', 'stop-shell-command', provider)
)
if (codeReviewInChat) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for re-directing the command >Amazon Q: Run Project Review in the top menu

@tsmithsz tsmithsz merged commit 632a570 into aws:master Jul 30, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants