-
Notifications
You must be signed in to change notification settings - Fork 664
feat(amazonq): adapt feature flag for CodeReviewInChat, emit metrics for explainIssue, applyFix #7739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+40
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bywang56
approved these changes
Jul 23, 2025
|
/retryBuilds |
laileni-aws
reviewed
Jul 30, 2025
@@ -64,14 +68,20 @@ export function registerCommands(provider: AmazonQChatViewProvider) { | |||
registerShellCommandShortCut('aws.amazonq.rejectCmdExecution', 'reject-shell-command', provider), | |||
registerShellCommandShortCut('aws.amazonq.stopCmdExecution', 'stop-shell-command', provider) | |||
) | |||
if (codeReviewInChat) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for re-directing the command >Amazon Q: Run Project Review in the top menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Adapt the CodeReviewInChat feature flag so that it applies to redirecting the commands which invoke /review
Emit telemetry events for explainIssue and applyFix
Solution
Move the feature flag value to a common location where it will be consumed
add telemetry emits based on earlier implementation
Set CodeReviewInChat feature flag to true (Requires merge after aws/language-servers#1964)
The duplicate code was not introduced by the commits in this PR, so we can ignore.
feature/x
branches will not be squash-merged at release time.