feat: SQL Editor - Syntax Coloring #3317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
min 6 lines gold border/orange border resize vertically by dragging the corner
|
I made some minor improvements, if the build pass I will merge the PR, good job! |
Helias
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SQL syntax with MySQL dialect and upper case auto completions. Highlighting uses the github light theme to match the existing HighlightJS highlighting
new dependencies
TLDR;
CodeMirror 6 wrapper for Angular
https://github.com/acrodata/code-editor
CodeMirror https://codemirror.net
sql lang support https://www.npmjs.com/package/@codemirror/lang-sql
CodeMirror github theme https://www.npmjs.com/package/@uiw/codemirror-theme-github
Closes
continuation of
feat(sql-editor-minor-improvements) #3173
Closes [Enhancement] - SQL Editor - Syntax Colouring! #3131
How to test
other libs for reference
❌ monaco: electronjs struggled with asset imports
❌ ace: soon to be or already deprecated for newer Angular versions