feat(Core/SetCurrentTrainer): Add multitrainer function

[manstfu]

Inregistrare.ecran.2025-02-07.200701.mp4

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Co-Author: @Winfidonarleyan & yangyitzzg

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[manstfu]

Eluna need update azerothcore/mod-eluna#254 after merge.

[TheSCREWEDSoftware]

I understand the outcome of this PR as you shown in the video.

How would as user would use this?

[sudlud]

Reminds me of #17988, if you've taken that pr as a basis please reference the original author correctly here.

[manstfu]

Reminds me of #17988, if you've taken that pr as a basis please reference the original author correctly here.

I have found that PR later and took only the title and @Winfidonarleyan suggestion with **[[nodiscard]]** uint32 GetCurrentTrainer() const { return m_currentTrainerEntry; }

You are free to co-author them!

[TheSCREWEDSoftware]

My question still stands. How would a user use this feature? Same for testing this PR

[manstfu]

Apply it as patch if required.

Eluna Patch

[YggdrasilWotLK]

As this is now closed, I just want to mention for future interested parties that this is already possible with existing Eluna API and some creativity like in the below framework:

local CREATURE_ID = 191000 -- Replace with your multi trainer's NPC ID

local TRAINERS = {
    [1] = 28704,  -- Herbalism Trainer
    [2] = 28694,  -- Blacksmithing Trainer
    [3] = 16771,   -- Warrior Trainer
    -- Add more trainers here, ensure the [number] aligns with the intid (final number) of the appropriate GossipMenuAddItem
}

local function OnGossipHello(event, player, creature)
    player:GossipMenuAddItem(0, "Herbalism Trainer", 0, 1)
    player:GossipMenuAddItem(0, "Blacksmithing Trainer", 0, 2)
    player:GossipMenuAddItem(0, "Warrior Trainer", 0, 3)
    -- Add trainer gossip options here
    player:GossipSendMenu(12, creature)
    return true
end

local function OnGossipSelect(event, player, creature, sender, intid)
    if TRAINERS[intid] then
        local trainer = creature:SpawnCreature(TRAINERS[intid], creature:GetX(), creature:GetY(), creature:GetZ(), creature:GetO(), 1, 30000)
        if trainer then
                trainer:SetDisplayId(25316) -- Setting temp trainer to invisible 
                player:GossipMenuAddItem(0, "Placeholder", 0, 1) -- Placeholder menu item to activate gossip
                player:GossipSendMenu(12, trainer) -- We must be in active gossip to send trainer list. After this, we can send the trainer list
                player:SendTrainerList(trainer) -- Now we can train from our new temp trainer
            end
        end
    end
end

RegisterCreatureGossipEvent(CREATURE_ID, 1, OnGossipHello)
RegisterCreatureGossipEvent(CREATURE_ID, 2, OnGossipSelect)

[TheSCREWEDSoftware]

I will rephrase my previous message so if i can get an answer to understand (not the result of this PR but how to use this PR).

If I was to download and compile this PR. How can I make a multi-trainer?

[Kitzunu]

okay I get the vision. But instead of tying it onto existing creature entries, I would like to see it tied to npc_trainer.ID

[manstfu]

okay I get the vision. But instead of tying it onto existing creature entries, I would like to see it tied to npc_trainer.ID

Not sure how to implement that.

[yuanf225]

Is PR ready for testing