Kil'Jaeden Ability Timers

[LuckyLuc96]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

chromiecraft/chromiecraft#8037

• The issue mentioned was the boss not casting his cycle of spells for phase 1 every 20 seconds, but every 40 seconds. The bug appears to be simply the timer having been too lenient in the script. This small change does appear to resolve the issue.

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. This fight looked normal to me, but I am not familiar with it. Please also observe his behavior.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Nyeriah]

If this proves correct, the ternary IF no longer serves a purpose in that statement

[LuckyLuc96]

If this proves correct, the ternary IF no longer serves a purpose in that statement

I agree. I'll change that and test the fight another time to make sure everything looks okay.

[LuckyLuc96]

Testing the boss fight more and everything seems to be working well. He doesn't cast Fire Bloom so much toward the end of the fight, because he is busy with a channeled spell. But it does get cast consistently around every 20 seconds.

Apologies for the 5 commits for the small change.

[kissingers]

Yes, the current skills of Kil'jaeden are quite weak. He is the easiest boss in the Sunwell because the timing intervals of some channeled abilities have not been taken into account.

[amed80]

First Fire Bloom is happening too early in P3 and P4, it's ~37s after the phase start , it should be ~48s at least (sometimes even +60s)
In P5, first Fire Bloom happens after ~50s , when in videos i never saw it happen before the first darkness cast (+70s)

If Fire Bloom gets delayed the next one will be casted too early such as 14s , the shortest timer between 2 Fire Bloom i have seen in videos is 17s.

Videos for reference: Video1 , Video2 , Video3 , Video4 , Video5 , Video6 , Video7

[LuckyLuc96]

I am going off my DBM addon to see how the fight is going along with expectations. Phases 3-5 seem right on target. Phase 2, it appears I may be pushing his shield ability to not trigger when expected.

Phase 1 seems normal. DBM still shows the flame ability as if it were a 40 second interval, but the original bug report provided evidence it should be 20 seconds.

It's still loading in, but here's a video of the fight with the current script. I think everything is good.

YT Link

Although I don't think phase 5 ever happened?

[amed80]

i think , you are changing the repeat timer with latest changes instead of the initial timer, it's why Fire Bloom "doesn't happen" in p5 as if it skips the first initial timer , it will have to wait 70s to repeat it?

Also for the timers , keep in mind there is always a delay by ~28s at the start of P3,P4 and P5, (caused by Shadow Spike)

[LuckyLuc96]

i think , you are changing the repeat timer with latest changes instead of the initial timer, it's why Fire Bloom "doesn't happen" in p5 as if it skips the first initial timer , it will have to wait 70s to repeat it?

Also for the timers , keep in mind there is always a delay by ~28s at the start of P3,P4 and P5, (caused by Shadow Spike)

I meant that, oddly enough, my fight doesn't seem to ever get to phase 5. At least according to the deadly boss mods announcements.

Edit - it seems that phase 5 IS phase 4. It's just a naming scheme I didn't recognize. Phase 1 starts with the hands before the boss emerges, and phase 2 is when the boss begins the fight.

[LuckyLuc96]

In this video from retail's TBC classic, this player is hit with Fire Bloom during phase 3 at 3:37 and you can see it cast again at 4:00, and is a 23 second delay

In this timestamp from same player is hit with Fire Bloom at 6:45 mark. Kil'jaeden casts firebloom around 7:08 after that. This is in phase 4 of 5, and is a 23 second delay

Phase 5, for this specific group at least, I can only see firebloom being cast a single time. I have the same effect during my testing with my alteration of setting a "cooldown" of 70 seconds with my edit of the Fire Bloom timer.

I tried to edit my timers to match this 23 second delay, but it resulted in him casting the fire bloom every 18ish seconds - which is too early. I'll try 25 to 27 and see how it works.

Setting the timers to 20 (phase 2), 25 (phases 3/4), and 40 (phase 5) gets me a pretty consistent cast of Fire Bloom every 20 seconds for phase 2, 3, and 4, and every 50ish seconds for phase 5. I am not sure why the timer seems to have a negative affect for phase 3/4, but I think the way it works out ingame is pretty good.

[heyitsbench]

This comment block isn't necessary for the final PR, given that the phases are already enumerated elsewhere in the file.

[LuckyLuc96]

You're right. I'll take it out.