-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(Core): make BGs and Arena prep time configurable #22136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NoxMax
wants to merge
15
commits into
azerothcore:master
Choose a base branch
from
NoxMax:Nox-PUSH-azerothcore-wotlk
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making BGs and Arena prep time configurable
Making BGs and Arena prep time configurable
Making BGs and Arena prep time configurable
Making BGs and Arena prep time configurable
Making BGs and Arena prep time configurable
Code style fix
Code style fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CORE
Related to the core
file-cpp
Used to trigger the matrix build
Ready to be Reviewed
Waiting to be Tested
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for reposting the PR. I accidentally closed the original -_-
Changes Proposed:
PR makes BGs and Arena prep time configurable in worldserver.conf. Keeping the default values of 120s/60s for BGs and Arena respectively. Now you don't have to wait if the default times are too long for you.
Making the timing configurable was simple, but making the timing announcements accurate is what required most of the work. Previous code logic had announcements triggered based on event flags rather than actual time values (full/half/quarter/none) The new code makes _ProcessJoin in Battleground.cpp actually aware how much time is left till match begins.
This PR proposes changes to:
Issues Addressed:
None on GH, but requested feature on Discord.
SOURCE:
N/A Default behavior has not been changed.
Tests Performed:
Compiled correctly on Debian.
Changes behaved as expected in-game.
This PR has been:
How to Test the Changes:
Please advise after testing if anything has been missed.
Known Issues and TODO List:
None for now.
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.