-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(Core): Add voice chat implementation. #22152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(Core): Add voice chat implementation. #22152
Conversation
Co-Authored-By: burlex <burlex@8ad44209-8f18-4ceb-bdfa-99d0be514da2> Co-Authored-By: celguar <[email protected]> Co-Authored-By: Jelle Meeus <[email protected]>
This is very work in progress. Opening now since I've been using the diff to look for things to fix, and it's easier when the PR is up. Plus any interested eyes can get on it and point out issues. |
Oh god, he is doing the thing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ready for prod
Wow awesome |
Hypothetical the usage / implemntation of the voice server would run along the auth and world? for exclusive 1 realm (1 per realm) or all realms? Even if it's a feature that seems under-use even now a days, I think this is a very cool addition. |
Not sure how the voice server itself responds to multiple connections, but ideally it would allow multiple to apply to multiple realms. Wouldn't make sense to limit itself to one realm by design, plus would cause problems for a possible cross-realm instance/battleground implementation. |
Original check on CMaNGOS is `IsBattleGroup`, which only returns for `m_bggroup`, so this matches original logic, but BFGroup does not exist in TBC branch, so must be added for Wrath.
Sets 0x80 for group(?) leader, 0xCA for all else. TODO: Account for leader switching.
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.