-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(DB/creature_loot) - Durar's and Kathorn's Power Cell corrected drop rate to 100% #22203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Please use an update file instead of modifying the base queries. You can refer to other pull requests that edit the database as a guide, or use this wiki page. |
3192081
to
049bf32
Compare
@@ -189766,7 +189766,7 @@ INSERT INTO `creature_loot_template` VALUES | |||
(26409,36674,0,0.1,0,1,0,1,1,'Rune-Smith Durar - Old Tooth'), | |||
(26409,36702,0,0.1,0,1,0,1,1,'Rune-Smith Durar - Melting Icestaff'), | |||
(26409,36852,0,1,1,1,0,1,1,'Rune-Smith Durar - War Golem Part'), | |||
(26409,36857,0,67,1,1,0,1,1,'Rune-Smith Durar - Durar\'s Power Cell'), | |||
(26409,36857,0,100,1,1,0,1,1,'Rune-Smith Durar - Durar\'s Power Cell'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not update the base SQL.
sql\updates\pending_db_world
Is the place where you run the bash file (create_sql) and make your query there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the SQL standards: https://www.azerothcore.org/wiki/sql-standards you can use bench's PR as a reference how to do it: https://github.com/azerothcore/azerothcore-wotlk/pull/22124/files
Edit: If you find proof that Kathorn's Power Cell
also should be a 100% you can update both. refering to this because the issued link refer to the other power cell.
@@ -0,0 +1,5 @@ | |||
-- Rune-Smith Durar - Durar\'s Power Cell | |||
UPDATE creature_loot_template SET Chance=100 WHERE Entry=26409 AND Item=36857; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use backticks for table name and column values as shown in the SQL standards.
Since they changes you're making is the same for both, you can have them in 1 query.
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
.quest add 12197
.go creature id 26409
Known Issues and TODO List:
/
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.