Quest - Imprisoned in the Citadel - Can now be completed.

[LuckyLuc96]

Quest is now completing appropriately for both factions.

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes [Quest] Imprisoned in the Citadel chromiecraft/chromiecraft#7948
• Closes Quest - Imprisoned in the Citadel - does not complete. #22230

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.
  

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. .mod rep 946 99999
2. .additem 30622 and .additem 28395
3. Enter heroic The Shattered Halls (.tele shatteredhalls)
4. Accept the quest at the midway point and complete it by killing the Executioner mob in-front of the prisoners.

Known Issues and TODO List:

• I discovered an adjacent bug that needs fixing, but I believe it's not related to my SQL. The horde captain's ingame ID is the exact same as the alliance captains. Strangely he acts like he should, and will allow you to turn in the quest. But if you kill him manually with .die and then .respawn him, he will respawn as the alliance captain. My smartAI script will ensure that the horde captain's death will result in quest failure. But I argue that this is not the real horde captain, but an imposter.

Note the NPC ID in the mouse-over information. The captain's ID is supposed to be 17296

2025-05-28.18-57-09.trimmed.mp4

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[heyitsbench]

INSERT INTO `quest_template_wotlk` (`ID`, `AllowableRaces`, `RequiredNpcOrGo1`) VALUES
(9524, 1791, 0),
(9525, 690, 0);

Sourced from 3.4.0 44832.

[TheSCREWEDSoftware]

1791

You sure it's 1791 for the alliance quest? that means eveveryone but a goblin can take it

[heyitsbench]

You sure it's 1791 for the alliance quest?

Sniffs say it is. Either way, the RequiredNpcOrGo change is incorrect according to sniffs, so this is a hackfix.

Was approved before I saw bench's sniff information.

[LuckyLuc96]

I'm convinced I went about fixing the quest the wrong way. I will look into it further and see about changing it without editing the quest_template data.