Fix various issues in code like AH restocking and proper item ratio due to not uising good enums values in AuctionHouseBot::Sell #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…\mod-ah-bot azerothcore#129 remove break in AuctionHouseBot::getNofAuctions to avoid always returning 1 auction when using ConsiderOnlyBotAuctions true
Fix Bug: wrong variable read from the config azerothcore#123 from azerothcore / mod-ah-bot azerothcore#123 Fix copy paste typo when reading config for ElapsingTimeClass
Merge some fix from multiple contriburors. Thanks to code from PixelWeaver, Icemansparks Added some sanity checks in AHBConfig::DecItemCounts made sure to remove auctions when item is not found Co-Authored-By: Dennis <[email protected]> Co-Authored-By: Antoine Cajot <[email protected]>
fix mistake withj unsigned int while hunting for the missing item auctions
revert back sql file to default values, git usage mistake
fix log error in AuctionHouseBot::Buy
Fixed a bunch of magic number and define values mismatch. AuctionHouseBotyConfig was getting out of sync with the actual Server database until a server restart ( where on initialization it would query the server AH for real)
Changed SQL query of buyer to only get auctions from relevant house. better logging on auction events in script manager
No need to stop selling item if above minimum and under maximum.
|
Thanks for your PR, please, solve the merge conflicts |
commented out unused param because of warning as errors
|
Conflicts resolved. |
Helias
reviewed
Feb 17, 2025
Helias
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
Issues Addressed:
Restocking items overtime correctly works with proper ratio.
SOURCE:
Tests Performed:
How to Test the Changes: