Adjust-command-logic #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created a new SQL table `beastmaster_tamed_pets` to store information about tamed pets. - Implemented functionality in `NpcBeastmaster.cpp` to track tamed pets, including methods for inserting, renaming, and deleting pets from the database. - Enhanced the gossip menu to include options for viewing and managing tracked pets. - Added a profanity filter and validation for pet names during renaming. - Introduced a chat handler for processing rename and delete confirmations. - Updated configuration loading to support new features related to tamed pets. - Refactored existing code for better organization and clarity, including the use of structured data types for pets.
Add features
- Removed redundant global tracked pets cache declaration and encapsulated it within the NpcBeastmaster class. - Introduced a mutex for thread-safe access to the tracked pets cache. - Added ClearTrackedPetsCache method to manage cache clearing for individual players. - Updated ShowTrackedPetsMenu to ensure thread safety when accessing the tracked pets cache. - Improved code readability and organization by adding comments and restructuring methods.
… management - Removed JSON dependency and related code for loading pet data. - Implemented SQL queries to fetch pet information from the database. - Simplified database operations for tracking tamed pets. - Introduced new structures for handling pet information and player actions. - Consolidated script classes into NpcBeastmaster for better organization. - Enhanced logging and error handling for database operations. - Updated gossip menu and chat handling for pet renaming and deletion.
…rove pet management features
…lity and organization - Split long lines into multiple lines for better readability. - Reorder includes in NpcBeastmaster.cpp for consistency. - Add constexpr for Beastmaster NPC entry and whistle item entry. - Enhance comments for clarity and maintainability. - Update logic for handling whispers and gossip menu interactions. - Implement a new OnChat method to handle pet renaming with validation. - Adjust spacing and formatting throughout the code for consistency.
…mmands, update README with usage instructions
… NpcBeastmaster.h
…s, improve configuration options for class and race restrictions, and add chat commands for summoning. Implement login notifications and refine pet adoption logic.
…nd improve formatting in header file
…ooldown message and improve PlayerScript constructor. Enhance logging format for registered commands.
…e override and improve clarity.
…ling in NpcBeastmaster
|
A change requested by TheScrewedSoftware: |
TheSCREWEDSoftware
approved these changes
May 25, 2025
|
CC: @Helias i don't have merge rights |
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust command logic as requested by AzerothCore.