Skip to content

fix: zoneconcierge ibc router #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2025
Merged

fix: zoneconcierge ibc router #1247

merged 4 commits into from
Jun 26, 2025

Conversation

gusin13
Copy link
Contributor

@gusin13 gusin13 commented Jun 19, 2025

was getting this in local deployment then realized, ibc router is missing for zc

  → Creating IBC channel for zoneconcierge...
2025-06-19T19:17:39.981605Z	info	Starting event processor for channel handshake	{"src_chain_id": "chain-test", "src_port_id": "zoneconcierge", "dst_chain_id": "bcd-test", "dst_port_id": "wasm.bbnc14hj2tavq8fpesdwxxcu44rty3hh90vhujrvcmstl4zr3txmfvw9syx25zf"}
2025-06-19T19:17:39.983040Z	info	Chain is in sync	{"chain_name": "bcd", "chain_id": "bcd-test"}
2025-06-19T19:17:39.983944Z	info	Chain is in sync	{"chain_name": "babylon", "chain_id": "chain-test"}
2025-06-19T19:17:50.222487Z	error	Error sending messages	{"path_name": "bcd", "src_chain_id": "bcd-test", "dst_chain_id": "chain-test", "src_client_id": "07-tendermint-0", "dst_client_id": "07-tendermint-0", "error": "rpc error: code = Unknown desc = rpc error: code = Unknown desc = failed to execute message; message index: 1: route not found to portID: zoneconcierge: route not found [cosmos/ibc-go/[email protected]/modules/core/keeper/msg_server.go:237] with gas used: '110088': unknown request"}
2025-06-19T19:18:22.278320Z	error	Error sending messages	{"path_name": "bcd", "src_chain_id": "bcd-test", "dst_chain_id": "chain-test", "src_client_id": "07-tendermint-0", "dst_client_id": "07-tendermint-0", "error": "rpc error: code = Unknown desc = rpc error: code = Unknown desc = failed to execute message; message index: 1: route not found to portID: zoneconcierge: route not found [cosmos/ibc-go/[email protected]/modules/core/keeper/msg_server.go:237] with gas used: '110138': unknown request"}
2025-06-19T19:18:54.326563Z	error	Error sending messages	{"path_name": "bcd", "src_chain_id": "bcd-test", "dst_chain_id": "chain-test", "src_client_id": "07-tendermint-0", "dst_client_id": "07-tendermint-0", "error": "rpc error: code = Unknown desc = rpc error: code = Unknown desc = failed to execute message; message index: 1: route not found to portID: zoneconcierge: route not found [cosmos/ibc-go/[email protected]/modules/core/keeper/msg_server.go:237] with gas used: '110088': unknown request"}
2025-06-19T19:19:26.378973Z	error	Error sending messages	{"path_name": "bcd", "src_chain_id": "bcd-test", "dst_chain_id": "chain-test", "src_client_id": "07-tendermint-0", "dst_client_id": "07-tendermint-0", "error": "rpc error: code = Unknown desc = rpc error: code = Unknown desc = failed to execute message; message index: 1: route not found to portID: zoneconcierge: route not found [cosmos/ibc-go/[email protected]/modules/core/keeper/msg_server.go:237] with gas used: '110306': unknown request"}

referred to Konrad's original commit which removed x/zoneconcierge - link

SebastianElvis
SebastianElvis previously approved these changes Jun 20, 2025
Copy link
Member

@SebastianElvis SebastianElvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

We can merge this fix for now. Any idea on how to write a unit test to ensure zone concierge is indeed a part of router?

Vvaradinov
Vvaradinov previously approved these changes Jun 20, 2025
Copy link
Contributor

@Vvaradinov Vvaradinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch.

KonradStaniec
KonradStaniec previously approved these changes Jun 20, 2025
Copy link
Collaborator

@KonradStaniec KonradStaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Do you think we can have a test that shows that this router is set up ? (tbh this should have been cought at Babylon level, not deployment level)

@gusin13
Copy link
Contributor Author

gusin13 commented Jun 24, 2025

Thanks for review! Yes for sure we need unit test - I'll add shortly and push here.
(pr got closed accidentally - reopened)

@gusin13
Copy link
Contributor Author

gusin13 commented Jun 26, 2025

Actually I'd have to merge this as this is blocking few things in local deployment.
Writing test needs some investigation - I'll add in separate pr, created ticket to track for now.

@gusin13 gusin13 merged commit e616715 into main Jun 26, 2025
28 checks passed
@gusin13 gusin13 deleted the gusin13/fix-zc-store branch June 26, 2025 02:29
mergify bot pushed a commit that referenced this pull request Jun 26, 2025
was getting this in local deployment then realized, ibc router is
missing for zc

```
  → Creating IBC channel for zoneconcierge...
2025-06-19T19:17:39.981605Z	info	Starting event processor for channel handshake	{"src_chain_id": "chain-test", "src_port_id": "zoneconcierge", "dst_chain_id": "bcd-test", "dst_port_id": "wasm.bbnc14hj2tavq8fpesdwxxcu44rty3hh90vhujrvcmstl4zr3txmfvw9syx25zf"}
2025-06-19T19:17:39.983040Z	info	Chain is in sync	{"chain_name": "bcd", "chain_id": "bcd-test"}
2025-06-19T19:17:39.983944Z	info	Chain is in sync	{"chain_name": "babylon", "chain_id": "chain-test"}
2025-06-19T19:17:50.222487Z	error	Error sending messages	{"path_name": "bcd", "src_chain_id": "bcd-test", "dst_chain_id": "chain-test", "src_client_id": "07-tendermint-0", "dst_client_id": "07-tendermint-0", "error": "rpc error: code = Unknown desc = rpc error: code = Unknown desc = failed to execute message; message index: 1: route not found to portID: zoneconcierge: route not found [cosmos/ibc-go/[email protected]/modules/core/keeper/msg_server.go:237] with gas used: '110088': unknown request"}
2025-06-19T19:18:22.278320Z	error	Error sending messages	{"path_name": "bcd", "src_chain_id": "bcd-test", "dst_chain_id": "chain-test", "src_client_id": "07-tendermint-0", "dst_client_id": "07-tendermint-0", "error": "rpc error: code = Unknown desc = rpc error: code = Unknown desc = failed to execute message; message index: 1: route not found to portID: zoneconcierge: route not found [cosmos/ibc-go/[email protected]/modules/core/keeper/msg_server.go:237] with gas used: '110138': unknown request"}
2025-06-19T19:18:54.326563Z	error	Error sending messages	{"path_name": "bcd", "src_chain_id": "bcd-test", "dst_chain_id": "chain-test", "src_client_id": "07-tendermint-0", "dst_client_id": "07-tendermint-0", "error": "rpc error: code = Unknown desc = rpc error: code = Unknown desc = failed to execute message; message index: 1: route not found to portID: zoneconcierge: route not found [cosmos/ibc-go/[email protected]/modules/core/keeper/msg_server.go:237] with gas used: '110088': unknown request"}
2025-06-19T19:19:26.378973Z	error	Error sending messages	{"path_name": "bcd", "src_chain_id": "bcd-test", "dst_chain_id": "chain-test", "src_client_id": "07-tendermint-0", "dst_client_id": "07-tendermint-0", "error": "rpc error: code = Unknown desc = rpc error: code = Unknown desc = failed to execute message; message index: 1: route not found to portID: zoneconcierge: route not found [cosmos/ibc-go/[email protected]/modules/core/keeper/msg_server.go:237] with gas used: '110306': unknown request"}
```

referred to Konrad's original commit which removed x/zoneconcierge -
[link](d640591)

(cherry picked from commit e616715)

# Conflicts:
#	app/keepers/keepers.go
#	x/zoneconcierge/module_ibc.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants