-
Notifications
You must be signed in to change notification settings - Fork 72
fix: zoneconcierge ibc router #1247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
We can merge this fix for now. Any idea on how to write a unit test to ensure zone concierge is indeed a part of router?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ! Do you think we can have a test that shows that this router is set up ? (tbh this should have been cought at Babylon level, not deployment level)
Thanks for review! Yes for sure we need unit test - I'll add shortly and push here. |
8b654e1
Actually I'd have to merge this as this is blocking few things in local deployment. |
was getting this in local deployment then realized, ibc router is missing for zc ``` → Creating IBC channel for zoneconcierge... 2025-06-19T19:17:39.981605Z info Starting event processor for channel handshake {"src_chain_id": "chain-test", "src_port_id": "zoneconcierge", "dst_chain_id": "bcd-test", "dst_port_id": "wasm.bbnc14hj2tavq8fpesdwxxcu44rty3hh90vhujrvcmstl4zr3txmfvw9syx25zf"} 2025-06-19T19:17:39.983040Z info Chain is in sync {"chain_name": "bcd", "chain_id": "bcd-test"} 2025-06-19T19:17:39.983944Z info Chain is in sync {"chain_name": "babylon", "chain_id": "chain-test"} 2025-06-19T19:17:50.222487Z error Error sending messages {"path_name": "bcd", "src_chain_id": "bcd-test", "dst_chain_id": "chain-test", "src_client_id": "07-tendermint-0", "dst_client_id": "07-tendermint-0", "error": "rpc error: code = Unknown desc = rpc error: code = Unknown desc = failed to execute message; message index: 1: route not found to portID: zoneconcierge: route not found [cosmos/ibc-go/[email protected]/modules/core/keeper/msg_server.go:237] with gas used: '110088': unknown request"} 2025-06-19T19:18:22.278320Z error Error sending messages {"path_name": "bcd", "src_chain_id": "bcd-test", "dst_chain_id": "chain-test", "src_client_id": "07-tendermint-0", "dst_client_id": "07-tendermint-0", "error": "rpc error: code = Unknown desc = rpc error: code = Unknown desc = failed to execute message; message index: 1: route not found to portID: zoneconcierge: route not found [cosmos/ibc-go/[email protected]/modules/core/keeper/msg_server.go:237] with gas used: '110138': unknown request"} 2025-06-19T19:18:54.326563Z error Error sending messages {"path_name": "bcd", "src_chain_id": "bcd-test", "dst_chain_id": "chain-test", "src_client_id": "07-tendermint-0", "dst_client_id": "07-tendermint-0", "error": "rpc error: code = Unknown desc = rpc error: code = Unknown desc = failed to execute message; message index: 1: route not found to portID: zoneconcierge: route not found [cosmos/ibc-go/[email protected]/modules/core/keeper/msg_server.go:237] with gas used: '110088': unknown request"} 2025-06-19T19:19:26.378973Z error Error sending messages {"path_name": "bcd", "src_chain_id": "bcd-test", "dst_chain_id": "chain-test", "src_client_id": "07-tendermint-0", "dst_client_id": "07-tendermint-0", "error": "rpc error: code = Unknown desc = rpc error: code = Unknown desc = failed to execute message; message index: 1: route not found to portID: zoneconcierge: route not found [cosmos/ibc-go/[email protected]/modules/core/keeper/msg_server.go:237] with gas used: '110306': unknown request"} ``` referred to Konrad's original commit which removed x/zoneconcierge - [link](d640591) (cherry picked from commit e616715) # Conflicts: # app/keepers/keepers.go # x/zoneconcierge/module_ibc.go
was getting this in local deployment then realized, ibc router is missing for zc
referred to Konrad's original commit which removed x/zoneconcierge - link