feat: add BSNs to delegationList #1155
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-babylonlabs
changed the base branch from
main
to
jb-implement-chain-selection
jeremy-babylonlabs
force-pushed
the
feat/delegation-list-bsn-support
branch
from
8e81bb6 to
1702ccc
Compare
jeremy-babylonlabs
requested review from
0xDazzer,
jonybur and
jrwbabylonlab
as code owners
0xDazzer
requested changes
Jun 24, 2025
| return ( | ||
| <AuthGuard> | ||
| <Section title="Activity"> | ||
| <Delegations /> | ||
| <DelegationList /> | ||
| {renderDelegationList()} |
There was a problem hiding this comment.
Suggested change
| {renderDelegationList()} | |
| {FeatureFlagService.IsPhase3Enabled ? | |
| <FinalityProviderBsnState> | |
| <DelegationList /> | |
| </FinalityProviderBsnState> | |
| : <DelegationList />} |
Comment on lines
+11
to
+14
| if (lowerCaseBsnName in chainLogos) { | ||
| return chainLogos[lowerCaseBsnName as BsnLogoKey]; | ||
| } | ||
| return chainLogos.placeholder; |
There was a problem hiding this comment.
Suggested change
| if (lowerCaseBsnName in chainLogos) { | |
| return chainLogos[lowerCaseBsnName as BsnLogoKey]; | |
| } | |
| return chainLogos.placeholder; | |
| return return chainLogos[lowerCaseBsnName as BsnLogoKey] ?? chainLogos.placeholder; |
Comment on lines
+177
to
+193
| const { getFinalityProvidersBsns } = useFinalityProviderBsnState(); | ||
|
|
||
| const handleBsnClick = (delegation: DelegationWithFP) => { | ||
| setBsnPreviewModal({ delegation }); | ||
| }; | ||
|
|
||
| const closeBsnPreviewModal = () => { | ||
| setBsnPreviewModal(null); | ||
| }; | ||
|
|
||
| const columnOrder = FeatureFlagService.IsPhase3Enabled | ||
| ? phase3ColumnOrder | ||
| : defaultColumnOrder; | ||
|
|
||
| const tableColumns = columnOrder | ||
| .map((key) => columnDefinitions.get(key)) | ||
| .filter(Boolean) as TableColumn<DelegationWithFP, TableParams>[]; |
There was a problem hiding this comment.
Just use a separate config for phase-3 table. You don't need change any logic here. Just reuse GridTable component with different configurations
| }, | ||
| ], | ||
| [ | ||
| "stakingTxHashHex", |
Comment on lines
+99
to
+104
| if (FeatureFlagService.IsPhase3Enabled) { | ||
| return { | ||
| ...delegationWithFP, | ||
| fps: allFinalityProviders, | ||
| }; | ||
| } |
There was a problem hiding this comment.
I don't think it's allowed to use FF on this level (actually we should use it only once in our code)
| export const SelectedBsnPreviewModal = ({ | ||
| onClose, | ||
| bsnList, | ||
| finalityProviders, |
There was a problem hiding this comment.
you only need FP here, cause you can always restore BSN from FP (FP has a BSN id)
Comment on lines
+34
to
+36
| {Array.from({ | ||
| length: Math.max(bsnList.length, finalityProviders.length), | ||
| }).map((_, index) => { |
There was a problem hiding this comment.
the comment from above would help you simplify this
Comment on lines
+69
to
+92
| <div className="w-8 h-8 rounded-lg bg-primary flex items-center justify-center flex-shrink-0"> | ||
| {fp.logo_url ? ( | ||
| <img | ||
| src={fp.logo_url} | ||
| alt={ | ||
| fp.description?.moniker || "Finality Provider" | ||
| } | ||
| className="w-6 h-6 rounded" | ||
| /> | ||
| ) : ( | ||
| <div className="w-6 h-6 bg-accent-secondary rounded flex items-center justify-center"> | ||
| <span className="text-xs text-white"> | ||
| {(fp.description?.moniker || "FP") | ||
| .charAt(0) | ||
| .toUpperCase()} | ||
| </span> | ||
| </div> | ||
| )} | ||
| </div> | ||
| <span className="text-accent-primary text-sm"> | ||
| {fp.description?.moniker || | ||
| "Unknown Finality Provider"} | ||
| </span> | ||
| </> |
There was a problem hiding this comment.
I'll review this one later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.