Skip to content

Issue #6935: Return 400 with less verbose text if trusted host check fails #5087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 1.x
Choose a base branch
from

Conversation

indigoxela
Copy link
Member

@backdrop-ci
Copy link
Collaborator

Related to: backdrop/backdrop-issues#6935

Copy link
Member

@yorkshire-pudding yorkshire-pudding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I've suggested a minor wording change.
Also, I wonder if 400 is right and whether we could be more specific; I will discuss in the issue.

Copy link
Member

@yorkshire-pudding yorkshire-pudding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dragonbot
Copy link
Collaborator

Tugboat has finished building a preview for this pull request!

Website: https://pr5087-dmmq9kc0wxkbf9txkoqmnzsdkbdrzg7t.tugboatqa.com/
Username: admin
Password: 8cb76efb2c1f

This preview will automatically expire on the 2nd of October, 2025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trusted host settings handling - multiple issues
4 participants