Simple client mode #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| ## Basic usage flow | ||
|
|
||
| 1. Server starts with gpg-group-chat --server at 192.168.0.1 | ||
| 2. The client1 starts with gpg-group-chat --client --server-ip=192.168.0.1 --public\_key=public\_key1 |
There was a problem hiding this comment.
Usually is used dash instead of underscore to separate words like "--public-key"
|
One more thing, just make sure the all this code pass on pep8. |
|
Just now I figured out that there are two issues on commit messages
|
jeffhsta
force-pushed
the
simple-client-mode
branch
from
b97fb45 to
885df49
Compare
ruanLN
force-pushed
the
simple-client-mode
branch
from
21646c0 to
75d466a
Compare
|
I think that is ready to merge 👍 |
|
I wouldn't merge it yet. It still missing tests and I got a refactoring in mind that we could do. @ruanLN we can schedule a time to pair on that, is that ok for you? |
- using a better IP example - adds line numbers on the list
- using a better IP example - adds line numbers on the list
Just naive receive message
…for example, i have added a placeholder to the encrypt function too
Break the method in other so separeted the logic
jeffhsta
force-pushed
the
simple-client-mode
branch
from
e68b740 to
e31263c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comparte to the client branch, maybe we can merge some of their code.
Fixes #4