Skip to content

Redis error #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 0.9.x
Choose a base branch
from
Open

Redis error #23

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5dee14
allow people to add an opError listener and use right connect listener
danjenkins May 16, 2014
adfbcba
add listeners
danjenkins May 19, 2014
4cbfe14
pass back the raw connection in the error callback
danjenkins May 20, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion lib/database/connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,26 @@ Connection.prototype.connect = function(cb) {
redis.createClient(config.port, config.host, config.options).auth(config.password) :
redis.createClient(config.port, config.host, config.options);

client.once('ready', function() {
if (config.options.onError) {
client.on('error', function connectionErrorListener(){
var args = Array.prototype.slice.call(arguments);
args.push(client);
config.options.onError.apply(this, args);
});
}

var event = 'ready';
if (config.options.no_ready_check) {
event = 'connect';
}

//cant share the listener below as thats tied with waterline business
if (config.options.onReady) {
client.on(event, config.options.onReady);
}

//make the client listen on on rather than once, a reconnect happens it needs to run the cb
client.once(event, function() {
cb(null, client);
});
};