Skip to content

Conversation

0xekkila
Copy link
Contributor

  • Current interface implementation defaults RPC link for Foundry Script to L1_RPC_URL. This fix should allow RPC url to be easily configurable through validation files.
  • Address a Github security issue with eip712sign functions. Even though the interface would be run locally and the exploits may never happen, this fix also contains a fix to follow security measurements.
  • Fix an issue where current link in github workflow comment does not work

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 2
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 2
2
1 if commit is unverified 0
Sum 2

@0xekkila 0xekkila force-pushed the thanh/interface-rpc-config branch from 3dcb305 to 399df7f Compare August 12, 2025 19:01
Copy link
Contributor

@jackchuma jackchuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having the config file saying the rpc type, it should specify the actual rpc url. The validation tool should only have to read the url from the config file

@cb-heimdall
Copy link
Collaborator

Review Error for jackchuma @ 2025-08-14 11:07:55 UTC
User failed mfa authentication, see go/mfa-help

@0xekkila 0xekkila requested a review from jackchuma August 15, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants