Skip to content

Add testnet parameter documentation for getPaymentStatus #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025

Conversation

spencerstock
Copy link
Contributor

@spencerstock spencerstock commented Jul 29, 2025

What changed? Why?

Added the testnet parameter to getPaymentStatus() function calls in the accept-payments documentation. This parameter must match the testnet setting used in the original pay() call to ensure payment status is checked on the correct network (mainnet vs testnet).

Added:

  • testnet: true parameter to the client-side example
  • Note explaining the importance of matching testnet parameters between pay() and getPaymentStatus() calls

How has it been tested?

Screenshot 2025-07-29 at 2 55 47 PM

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jul 29, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@youssefea youssefea merged commit 90e5005 into master Jul 29, 2025
7 checks passed
@youssefea youssefea deleted the spencer/testnet-for-accept-payments branch July 29, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants