Skip to content

reth-entrypoint: use safe parameter expansion to prevent set -u unbound variable errors #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Snezhkko
Copy link

Reason: With set -u, referencing unset variables in conditions (e.g., [[ -z "$RETH_CHAIN" ]] and checking RETH_FB_WEBSOCKET_URL) causes an “unbound variable” error, terminating the script unexpectedly.
Change: Updated conditional checks to use safe expansion ${RETH_CHAIN:-} and ${RETH_FB_WEBSOCKET_URL:-}.
Goal: Prevent crashes when optional env vars are unset while preserving existing behavior when they are provided.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants