Parallel hash computations #163
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes hash computations happen in parallel in a thread pool. While hashes are computed in the background, a temporary, zero-byte hash is written to the pages. The zero hashes are replaced with the actual hashes once all changes have been processed.
Status of this PR: All tests are passing, but this is a very early draft that needs a lot of cleanup and refactoring.
TODO
DeferredChanges
struct insideContext
.slotted_page.set_value(...); deferred.set_value(...)
becomes 1 call.DeferredRlpNode
has replacedRlpNode
almost everywhere. In practice,DeferredRlpNode
is only needed when writing values, but when reading,RlpNode
is enough, and has a lower overhead.Pointer
should become a genericPointer<R>
so that bothRlpNode
andDeferredRlpNode
can be used as appropriate.'lazy_static
.