-
Notifications
You must be signed in to change notification settings - Fork 1.4k
added an icon to waybar when the notifications are silenced #2136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
added an icon to waybar when the notifications are silenced #2136
Conversation
Note: This is my first PR, so please let me know if I missed any steps or if the procedure could be improved. |
This is great, but we need a migration that adds the new elements to the waybar config and style. Should use grep/sed, so we don't have to refresh the entire bar and overwrite people's configurations, if we can avoid it. |
Would some sort of update script for waybar that dynamically add the new elements do the trick? I wonder how to refresh the entire bar without overwriting peoples's configuration. I haven't thought of the fact that adding elements to the defaults would overwrite people's configuration :(. |
You can check how some of the other migrations do it. Basically, you'll look for the string that's next to what you want to add, then dynamically add it. |
I have added a migration script that dynamically change ~/.config/waybar/style.css and ~/.config/waybar/config.jsonc. I have tested it on the files from the master branch and I get the same as my feature branch. If the sed does not find the lines to change, then nothing happen (I don't want peoples config to get overwrite!). Still it makes a backup file just in case. I did not make an migration for the default bindings, because I assume people don't mess with this file. |
This pull request introduces a do-not-disturb indicator to Waybar. The changes add a new visual indicator for do-not-disturb mode, update notification keybindings to refresh the indicator, and implement the supporting script.
Waybar do-not-disturb indicator integration:
custom/do-not-disturb-indicator
module to the center of Waybar, providing a visual cue when notifications are silenced. No indicators are visible when notifications are not silenced. (config/waybar/config.jsonc
)custom/do-not-disturb-indicator
module to toggle do-not-disturb mode and display a notification when clicked, using a custom script for status updates. (config/waybar/config.jsonc
)do-not-disturb.sh
script to output indicator status in JSON format based on current notification mode. (default/waybar/indicators/do-not-disturb.sh
)Notification keybinding improvements:
default/hypr/bindings/utilities.conf
)