feat(currency): Currency switcher #175
Open
+81
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacquelineKlimmek
requested review from
aheartforspinach,
m-borgmann,
mloeffle,
jkniest,
chlongng and
MorennMcFly
as code owners
JacquelineKlimmek
temporarily deployed
to
review-175
GitHub Actions
Inactive
WalkthroughA currency switching feature was introduced. This includes a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CurrencySwitcherInner
participant usePondSalesChannel
participant ShopwareApiClient
participant SessionContext
User->>CurrencySwitcherInner: Mount component
CurrencySwitcherInner->>SessionContext: Get current currency
CurrencySwitcherInner->>usePondSalesChannel: getAvailableCurrencies()
usePondSalesChannel->>ShopwareApiClient: Fetch available currencies
ShopwareApiClient-->>usePondSalesChannel: Return currency list
usePondSalesChannel-->>CurrencySwitcherInner: Return currency list
CurrencySwitcherInner->>User: Render dropdown with currencies
User->>CurrencySwitcherInner: Select new currency
CurrencySwitcherInner->>SessionContext: Update current currency
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
JacquelineKlimmek
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
components/CurrencySwitcher.vue(1 hunks)components/CurrencySwitcherInner.vue(1 hunks)components/layout/footer/LayoutFooterInner.vue(1 hunks)composables/usePondSalesChannel.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: review-app
🔇 Additional comments (4)
composables/usePondSalesChannel.ts (2)
1-15: Well-structured composable with proper caching and error handling.The composable follows good patterns with dependency injection, caching, and error handling. The API integration looks correct for Shopware's sales channel.
8-11: ```shell
#!/bin/bashDisplay CurrencySwitcherInner.vue to verify null handling after API failure
sed -n '1,200p' components/CurrencySwitcherInner.vue
</details> <details> <summary>components/CurrencySwitcher.vue (1)</summary> `1-3`: **Good wrapper pattern for component composition.** Clean implementation using the wrapper pattern, allowing for separation of concerns between layout and logic components. </details> <details> <summary>components/layout/footer/LayoutFooterInner.vue (1)</summary> `52-56`: **Well-positioned currency switcher slot with responsive design.** The slot placement between navigation sections is logical, and the responsive CSS classes properly handle mobile (`w-full mt-5`) and desktop (`md:mt-0 md:w-auto`) layouts with appropriate alignment. </details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
JacquelineKlimmek
temporarily deployed
to
review-175
GitHub Actions
Inactive
chlongng
approved these changes
Jun 23, 2025
components/CurrencySwitcherInner.vue
Outdated
Comment on lines
8
to
9
| const availableCurrencies: Ref<null | Schemas['Currency'][]> = ref(null); | ||
| const selectedCurrencyId: Ref<null | AcceptableValue> = ref(null); |
There was a problem hiding this comment.
Suggested change
| const availableCurrencies: Ref<null | Schemas['Currency'][]> = ref(null); | |
| const selectedCurrencyId: Ref<null | AcceptableValue> = ref(null); | |
| const availableCurrencies: Ref<undefined | Schemas['Currency'][]> = ref(undefined); | |
| const selectedCurrencyId: Ref<undefined | AcceptableValue> = ref(undefined); |
https://cookbook.bscm.academy/general/codingConventionsTypescript/#undefined-instead-of-null
components/CurrencySwitcherInner.vue
Outdated
| <UiSelectContent> | ||
| <UiSelectGroup> | ||
| <UiSelectItem | ||
| v-for="availableCurrency in availableCurrencies || []" |
There was a problem hiding this comment.
why not using a v-if to check whether its undefined?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit