fix(account): Fixed Vat ID in personal data form #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacquelineKlimmek
requested review from
aheartforspinach,
m-borgmann,
mloeffle and
jkniest
as code owners
## Walkthrough
The changes standardize the handling of the VAT IDs field across the account profile components and composables. The VAT IDs field key is renamed from `'vatIds[]'` to `vatIds` in form schemas and template slots, and the value is converted to an array before being sent to the API, ensuring compatibility with backend expectations.
## Changes
| File(s) | Change Summary |
|--------------------------------------------------------------------|---------------------------------------------------------------------------------------------------|
| components/account/page/AccountPageProfile.vue | Converts `vatIds` from a string to an array before API call in `doUpdatePersonalData`. |
| components/account/page/AccountPageProfileInner.vue | Corrects Vue template slot name from `vatIds[]` to `vatIds`. |
| composables/usePondForm.ts | Renames form schema key from `'vatIds[]'` to `vatIds` in `getPersonalDataForm` and dependencies. |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant User
participant AccountPageProfile
participant API
User->>AccountPageProfile: Submit personal data form (vatIds as string)
AccountPageProfile->>AccountPageProfile: Convert vatIds string to array
AccountPageProfile->>API: updatePersonalInfo({ ...personalDataForm, vatIds: [vatIds] })
API-->>AccountPageProfile: Response
AccountPageProfile-->>User: Show result |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (2)
composables/usePondForm.ts (1)
80-80: Critical inconsistency: Update dependency target field name.The dependency configuration still references
'vatIds[]'but the schema field was renamed tovatIdson line 44. This will break the conditional hiding logic for the VAT ID field.Apply this diff to fix the inconsistency:
- targetField: 'vatIds[]', + targetField: 'vatIds',components/account/page/AccountPageProfileInner.vue (1)
94-94: Critical inconsistency: Update field config key to match template slot.The field config still references
'vatIds[]'for the label, but the template slot was renamed tovatIdson line 159. This inconsistency will prevent the label from being properly associated with the field.Apply this diff to fix the inconsistency:
- 'vatIds[]': { label: $t('account.customer.vat') }, + vatIds: { label: $t('account.customer.vat') },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
components/account/page/AccountPageProfile.vue(1 hunks)components/account/page/AccountPageProfileInner.vue(1 hunks)composables/usePondForm.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: review-app
🔇 Additional comments (2)
composables/usePondForm.ts (1)
44-44: LGTM! Field naming standardized.The schema field key has been correctly updated from
'vatIds[]'tovatIdsto standardize the naming convention.components/account/page/AccountPageProfileInner.vue (1)
159-159: LGTM! Template slot name corrected.The template slot name has been correctly updated from
vatIds[]tovatIdsto align with the standardized field naming.
jkniest
approved these changes
Jun 19, 2025
aheartforspinach
approved these changes
Jun 20, 2025
aheartforspinach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit