feat: determine initramfs tool by command presence instead of release files #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files The previous implementation of rebuild_initramfs() relied on checking the distribution's release files (e.g. /etc/arch-release, /etc/debian_version) to determine the appropriate initramfs tool. This approach was unreliable because the release files may not indicate the actual initramfs tool in use, especially in Arch Linux where multiple tools such as mkinitcpio, dracut, or booster may be configured. The new implementation solves this problem by using shutil.which to determine if certain commands (update-initramfs, dracut, mkinitcpio, /usr/lib/booster/regenerate_images, etc.) are present, providing a more reliable and universal method of selecting the correct initramfs tool Signed-off-by: Boris Yumankulov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of rebuild_initramfs() relied on checking the distribution's release files (e.g. /etc/arch-release, /etc/debian_version) to determine the appropriate initramfs tool. This approach was unreliable because the release files may not indicate the actual initramfs tool in use, especially in Arch Linux where multiple tools such as mkinitcpio, dracut, or booster may be configured. The new implementation solves this problem by using shutil.which to determine if certain commands (update-initramfs, dracut, mkinitcpio, /usr/lib/booster/regenerate_images, etc.) are present, providing a more reliable and universal method of selecting the correct initramfs tool