Allow urls in llvm_extra_distributions #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fmeum can I ask you for a review? |
helly25
force-pushed
the
feat/extra_llvm_distributions_20250517
branch
from
e3e8dba to
a092e3e
Compare
|
@fmeum can I ask you for a review? |
helly25
force-pushed
the
feat/extra_llvm_distributions_20250517
branch
from
a092e3e to
216e9f0
Compare
fmeum
approved these changes
Jun 4, 2025
|
Sorry for the delay, it's a busy period for me |
NW. I saw you're working on some super-duper cool stuff :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In extra_llvm_distributions allow URLs and absolute filenames. If absolute filenames are used, then we turn them into "file:" urls which are also understood.
If strip_prefix is not given, then we compute it.
Extend tests to verify llvm_extra_distributions actually work.
Also stop reporting aliasing of sparc64 and sparcv9 as error.
Next step: