bindgen: Pass -resource-dir Clang flag to bindgen-cli.
#3591
+115
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinboehme
force-pushed
the
resource_dir
branch
2 times, most recently
from
7feb685 to
0115547
Compare
For some cc_toolchain configurations, this is required to find the builtin headers. So far, the bindgen rules had assumed that the builtin headers can be found through `cc_toolchain.built_in_include_directories`. This is, however, not guaranteed to be the case; indeed, `built_in_include_directories` is not really intended for finding builtin headers but merely for filtering out diagnostics in builtin headers. Clang itself finds the resource directory relative to its own binary, and then finds the builtin headers in the "include" subdirectory of the resource directory. bindgen-cli may, however, be located in a different directory than Clang, so we pass a `-resource-dir` flag on the command line.
martinboehme
force-pushed
the
resource_dir
branch
from
0115547 to
75c4d96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some cc_toolchain configurations, this is required to find the builtin
headers.
So far, the bindgen rules had assumed that the builtin headers can be
found through
cc_toolchain.built_in_include_directories. This is,however, not guaranteed to be the case; indeed,
built_in_include_directoriesis not really intended for findingbuiltin headers but merely for filtering out diagnostics in builtin
headers.
Clang itself finds the resource directory relative to its own binary,
and then finds the builtin headers in the "include" subdirectory of the
resource directory. bindgen-cli may, however, be located in a different
directory than Clang, so we pass a
-resource-dirflag on the commandline.