Cleaned up the CI a little. #38
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the PR gets a +1 from the reviewers, I will need to rebase this PR to remove the first commit (29018de) so that it can be merged to
main
. I needed to add the branch to the CI to ensure that my changes weren't breaking anything.In this PR, I
Ubuntu 24.04
runner, we can see that Ninja comes preinstalled. (For further information, this change seems to have been made near the beginning of the year.)rm -rf .build
step. The runners only come with the default directories. If we didn't make the.build
directory in a previous step, then it cannot exist.set -x
. Running that once is enough. The shell persists across the different steps.cat /etc/lsb_release
. It is fine to use that during the development of the CI, but there is no reason to run it every CI run. It just adds to the logs for no reason. We specifically asked for theUbuntu 24.04
runner, so all the information we might need to know can be found in the specs for the GitHub-hostedUbuntu 24.04
runner.Apart from these, I want to also remove the "Install LLVM + Clang" and "Install GCC" steps. Not only would it make the CI script simpler (and therefore reduce the maintenance burden a bit), but also because the current method of doing things makes no sense to me. The
Ubuntu 24.04
runner comes with Clang 16-18 and GCC 12-14 preinstalled. So, I don't quite see the value of removing it and then readding it.For Clang, we can remove the current "Install LLVM+Clang" step and use the
Install LLVM and Clang
Action, which would greatly simplify the script, reduce maintenance burden, and remove the need to reinvent the wheel.For GCC, as far as I can tell, there is no reason for the
Install GCC
step to exist. All the 3 GCC versions we test against are preinstalled in the runner.I'd be happy to make these changes, but I wanted to get some feedback from the maintainers/community first.