-
Notifications
You must be signed in to change notification settings - Fork 129
feat: Add linting scripts for ESLint and MarkdownLint #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Updated package.json to include separate linting scripts for ESLint and MarkdownLint. - Added fix options for both ESLint and MarkdownLint. - Included markdownlint-cli as a dependency.
package-lock.json
Outdated
{ | ||
"name": "@benborla29/mcp-server-mysql", | ||
"version": "2.0.5", | ||
"name": "@bulgariamitko/mcp-server-mysql-write", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming this was due to a change in the name from the package.json
file, but both may need to be set back to the original. Seems a little risky to me to be changing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and reverted. Looks like this was change in PR #77
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ackage-lock.json - Reverting package name & description to original author in `package.json` and `package-lock.json`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to remove this workflow. Would love to see markdown lint checks, but don't want to hold up the build pipeline due to failure.
@benborla Is this something you can look at, or do you want me to close this PR? |
Reasoning: Because I take clean markdown very seriously 🤣