Fix module.exports object literal transformation to ESM exports #166
+82
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where
module.exports = { ... }
object literals were being stripped entirely instead of being transformed to proper ESM exports.Problem
Previously, when transforming CommonJS to ESM, the following pattern would be incorrectly handled:
Before (incorrect): The entire
module.exports
statement was stripped, leaving only:After (correct): Now properly transforms to ESM exports:
Solution
Enhanced the
replaceModuleExports
function insrc/converter/replacer/replaceModuleExports.ts
to handle object literal expressions by:SyntaxKind.ObjectLiteralExpression
alongside existing identifier and function expression handling{ c0, c1 }
toexport { c0, c1 }
{ a: valueA, b: valueB }
toexport { valueA as a, valueB as b }
{ x, z: y }
→export { x, y as z }
The implementation uses ts-morph's AST parsing to properly extract property names and values from object literals, generating the appropriate ESM export declarations.
Testing
Added comprehensive test coverage with three new test cases covering all scenarios:
All existing tests continue to pass, ensuring backward compatibility.
Fixes #125.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.