-
Notifications
You must be signed in to change notification settings - Fork 77
Add initializing wallet configuration with bdk-cli wallet init
#203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
9e56084
to
b3966e3
Compare
Pull Request Test Coverage Report for Build 15923676961Details
💛 - Coveralls |
b3966e3
to
bf14df8
Compare
I like the approach for loading the config file parameters if the file exists, but is there a reason you didn't add a CLI Creating the config file in rust should be easier to maintain/keep in sync than your |
Alright, I will update. |
- add config.rs to store and retrieve values - add toml and serde crates for desearilizing and reading values - update utils, commands and handlers files to use values from config.toml -refactor prepare_wallet_db fn - fix clippy issues [Issue: bitcoindevkit#192]
bf14df8
to
36ee973
Compare
bdk-cli wallet init
a99ff5d
to
5125cf8
Compare
- update wallet initialization to use `bdk-cli wallet init` command directly and read walletopts - update README for how to use the bdk-cli wallet init command - fix clippy warnings [Issue: bitcoindevkit#192]
5125cf8
to
fcf7ce8
Compare
@notmandatory I have updated the PR |
Description
This PR adds
bdk-cli wallet init
command to save wallet configuration information toconfig.toml
file in the data directory.Fixes #192
Notes to the reviewers
serde
crate frombdk_wallet
did not offer thederive
featureChecklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
CHANGELOG.md